Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array-changes.js:117 _dispatchOwnPropertyChange #227

Open
marchant opened this issue Oct 1, 2019 · 0 comments
Open

array-changes.js:117 _dispatchOwnPropertyChange #227

marchant opened this issue Oct 1, 2019 · 0 comments
Assignees
@marchant
Labels
performance

Comments

@marchant
Copy link
Member

marchant commented Oct 1, 2019

For each iteration, this.dispatchOwnPropertyChange(i, this[i]); keeps calling's PropertyChanges.prototype.getOwnPropertyChangeDescriptor, which navigates internal structure every time. Adding some caching to avoid doing that would help speed things up quite a bit.
@marchant marchant self-assigned this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marchant marchant

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marchant