Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language String (edit mode) #3

Open
I123U opened this issue Nov 18, 2024 · 0 comments
Open

Language String (edit mode) #3

I123U opened this issue Nov 18, 2024 · 0 comments

Comments

@I123U
Copy link

I123U commented Nov 18, 2024

Hello, when editing a H5P in the content bank, with debug turned on, I see these issues related to language strings.
tring translation cannot be found. Please add a string definition for 'Rotate Left' in the core_h5p component.

line 462 of /h5p/classes/framework.php: call to debugging()
line 3794 of /h5p/h5plib/v127/joubel/core/h5p.classes.php: call to core_h5p\framework->t()
line 379 of /h5p/classes/helper.php: call to Moodle\H5PCore->getLocalization()
line 402 of /h5p/classes/helper.php: call to core_h5p\helper::get_core_settings()
line 346 of /h5p/classes/editor.php: call to core_h5p\helper::get_core_assets()
line 194 of /h5p/classes/editor.php: call to core_h5p\editor->add_assets_to_page()
line 118 of /contentbank/contenttype/h5p/classes/form/editor.php: call to core_h5p\editor->add_editor_to_form()
line 214 of /lib/formslib.php: call to contenttype_h5p\form\editor->definition()
line 59 of /contentbank/classes/form/edit_content.php: call to moodleform->__construct()
line 118 of /contentbank/edit.php: call to core_contentbank\form\edit_content->__construct()

String translation cannot be found. Please add a string definition for 'Rotate Right' in the core_h5p component.

line 462 of /h5p/classes/framework.php: call to debugging()
line 3795 of /h5p/h5plib/v127/joubel/core/h5p.classes.php: call to core_h5p\framework->t()
line 379 of /h5p/classes/helper.php: call to Moodle\H5PCore->getLocalization()
line 402 of /h5p/classes/helper.php: call to core_h5p\helper::get_core_settings()
line 346 of /h5p/classes/editor.php: call to core_h5p\helper::get_core_assets()
line 194 of /h5p/classes/editor.php: call to core_h5p\editor->add_assets_to_page()
line 118 of /contentbank/contenttype/h5p/classes/form/editor.php: call to core_h5p\editor->add_editor_to_form()
line 214 of /lib/formslib.php: call to contenttype_h5p\form\editor->definition()
line 59 of /contentbank/classes/form/edit_content.php: call to moodleform->__construct()
line 118 of /contentbank/edit.php: call to core_contentbank\form\edit_content->__construct()

String translation cannot be found. Please add a string definition for 'Crop Image' in the core_h5p component.

line 462 of /h5p/classes/framework.php: call to debugging()
line 3796 of /h5p/h5plib/v127/joubel/core/h5p.classes.php: call to core_h5p\framework->t()
line 379 of /h5p/classes/helper.php: call to Moodle\H5PCore->getLocalization()
line 402 of /h5p/classes/helper.php: call to core_h5p\helper::get_core_settings()
line 346 of /h5p/classes/editor.php: call to core_h5p\helper::get_core_assets()
line 194 of /h5p/classes/editor.php: call to core_h5p\editor->add_assets_to_page()
line 118 of /contentbank/contenttype/h5p/classes/form/editor.php: call to core_h5p\editor->add_editor_to_form()
line 214 of /lib/formslib.php: call to contenttype_h5p\form\editor->definition()
line 59 of /contentbank/classes/form/edit_content.php: call to moodleform->__construct()
line 118 of /contentbank/edit.php: call to core_contentbank\form\edit_content->__construct()

String translation cannot be found. Please add a string definition for 'Confirm Crop' in the core_h5p component.

line 462 of /h5p/classes/framework.php: call to debugging()
line 3797 of /h5p/h5plib/v127/joubel/core/h5p.classes.php: call to core_h5p\framework->t()
line 379 of /h5p/classes/helper.php: call to Moodle\H5PCore->getLocalization()
line 402 of /h5p/classes/helper.php: call to core_h5p\helper::get_core_settings()
line 346 of /h5p/classes/editor.php: call to core_h5p\helper::get_core_assets()
line 194 of /h5p/classes/editor.php: call to core_h5p\editor->add_assets_to_page()
line 118 of /contentbank/contenttype/h5p/classes/form/editor.php: call to core_h5p\editor->add_editor_to_form()
line 214 of /lib/formslib.php: call to contenttype_h5p\form\editor->definition()
line 59 of /contentbank/classes/form/edit_content.php: call to moodleform->__construct()
line 118 of /contentbank/edit.php: call to core_contentbank\form\edit_content->__construct()

String translation cannot be found. Please add a string definition for 'Cancel Crop' in the core_h5p component.

line 462 of /h5p/classes/framework.php: call to debugging()
line 3798 of /h5p/h5plib/v127/joubel/core/h5p.classes.php: call to core_h5p\framework->t()
line 379 of /h5p/classes/helper.php: call to Moodle\H5PCore->getLocalization()
line 402 of /h5p/classes/helper.php: call to core_h5p\helper::get_core_settings()
line 346 of /h5p/classes/editor.php: call to core_h5p\helper::get_core_assets()
line 194 of /h5p/classes/editor.php: call to core_h5p\editor->add_assets_to_page()
line 118 of /contentbank/contenttype/h5p/classes/form/editor.php: call to core_h5p\editor->add_editor_to_form()
line 214 of /lib/formslib.php: call to contenttype_h5p\form\editor->definition()
line 59 of /contentbank/classes/form/edit_content.php: call to moodleform->__construct()
line 118 of /contentbank/edit.php: call to core_contentbank\form\edit_content->__construct()

If a student role visits a H5P, that was previously on version 126 of the libraries (with debug on) but has not yet been re-saved, which should upgrade the H5P to the 127 libraries I see similar language string issues, short example:

"String translation cannot be found. Please add a string definition for 'Rotate Left' in thee core_h5p component."

There are other similar translation issues.

When re-saving the H5P and viewing again as a student role with debug on, these lang errors do not show.
However, the lagnuage string issues continue to show in edit mode after re-saving the H5P.

So, it appears there are some undefined language strings that require updating for v127 libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant