Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Stop using CryptoTypePublicPair directly #16

Open
JoshOrndorff opened this issue Nov 4, 2021 · 0 comments
Open

Stop using CryptoTypePublicPair directly #16

JoshOrndorff opened this issue Nov 4, 2021 · 0 comments
Assignees

Comments

@JoshOrndorff
Copy link
Contributor

When I was first learning the keystore, I fumbled with the types a lot. I ended up getting something that compiled and worked, so I stuck with it. Now it seems more clear that we should be using NimbusIds directly, and calling .into() on them when we really need a CryptoTypePublicPair.

This change needs to be made throughout the nimbus-consensus crate. Especially in the parachain worker and the manual seal ConsensusDataProvider.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants