Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed for release MoonShine #13

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Fixed for release MoonShine #13

merged 3 commits into from
Nov 3, 2024

Conversation

DissNik
Copy link
Member

@DissNik DissNik commented Oct 30, 2024 

Layouts::make('Content')
    ->addLayout('Contact information', 'contacts', [
        Grid::make([
            Column::make([
                Text::make('Name'),
            ])
                ->columnSpan(6),
            Column::make([
                Email::make('Email'),
            ])
                ->columnSpan(6),
        ])
    ])

lee-to
lee-to reviewed Oct 30, 2024
View reviewed changes
src/Fields/Layouts.php
@@ -169,9 +171,15 @@ public function getFilledLayouts(): LayoutCollection
return LayoutCollection::make($filled);
}

private function fillClonedRecursively(Collection $collection, mixed $data): Collection
private function fillClonedRecursively(ComponentsContract|Collection $collection, mixed $data): Collection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кстати глянь помоему этот метод есть в коробке муншайн и может можно заменить на него

@lee-to lee-to merged commit 5539cc0 into moonshine-software:2.x Nov 3, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee-to lee-to lee-to left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DissNik @lee-to