Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In facet-cut command, if user does not wish to call an initializer, CLI raises error about lack of initializer calldata #323

Open
zomglings opened this issue Jul 27, 2023 · 0 comments
Open

In facet-cut command, if user does not wish to call an initializer, CLI raises error about lack of initializer calldata #323

zomglings opened this issue Jul 27, 2023 · 0 comments
Assignees
@zomglings
Labels
bug Something isn't working

Comments

@zomglings
Copy link
Collaborator

Just leaving out --initializer-address raises an error incorrectly because for contract initializers that take arguments, the CLI requests --initializer-args to be nonempty even if --initializer-address has not been specified.

We should make it so that the initializer calldata is only populated if the initializer_address is neither None nor the 0 address.

This fix needs to be applied in core.py.
@zomglings zomglings added the bug Something isn't working label Jul 27, 2023
@zomglings zomglings self-assigned this Jul 27, 2023
zomglings pushed a commit that referenced this issue Jul 27, 2023
Updated core.py to contain inventory_gogogo and related functionality
9022045 
As a part of this, I also added:

1. The ability to specify existing facets for diamond_gogogo and for
   inventory_gogogo. This lays the foundation to eventually resolve
   #315

2. A fix for #323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zomglings zomglings

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zomglings