Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire event on Terminus pool URI updates #337

Open
zomglings opened this issue Sep 5, 2023 · 0 comments
Open

Fire event on Terminus pool URI updates #337

zomglings opened this issue Sep 5, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers smart contract

Comments

@zomglings
Copy link
Collaborator

Currently, we do not fire an event when we update the metadata URI for a Terminus pool (via an on-chain transaction).

It would be good for us to do so - it would make it easier for external websites to display the correct information for Terminus pools from their caches.

Perhaps we should follow ERC-4906.
@zomglings zomglings added bug Something isn't working good first issue Good for newcomers smart contract enhancement New feature or request and removed bug Something isn't working labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers smart contract
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zomglings