Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search with drop-down@allow-multiple not working when form-list@header-dialog=false #105

Open
jenshp opened this issue Oct 31, 2017 · 2 comments

Comments

@jenshp
Copy link
Member

jenshp commented Oct 31, 2017

Searching an entity with search-form-inputs fails when:

  1. using vuet
  2. having a drop-down with @allow-multiple == true
  3. selecting more than one option within that drop-down
  4. the form-list@header-dialog == false (the default)

If you change the form-list@header-dialog to true, select only one option or use the same screen through the /apps rather than /vapps URL it finds the results, but when all four conditions above are met, no results are shown.

When printing the parameter with the respective field name immediately after the entity-find, the difference is that when it is working it has a list form (e.g. "[option1, option2]") and when it is not working it does not print the starting nor ending brackets (e.g. "option1, option2").

@jonesde
Copy link
Member

jonesde commented Nov 19, 2017

Steps to reproduce:

  1. start with latest from PopCommerce (including all dependencies)
  2. load demo data and run tests (gradle load test)
  3. change the FindOrder.xml screen in SimpleScreens
    3.a. set header-dialog="true" for the OrderList form
    3.b. add to the submitButton field in the OrderList form (this may not be the easiest way to reproduce this as the form is designed for header-dialog using the current rendering macros)
  4. run moqui (java -jar moqui.war)
  5. go to http://localhost:8080/vapps/PopcAdmin/Order
  6. in the Status field in the header clear out default options and select the first 2, then click on the Find button

The result for me was the 2 statuses I selected (the first 2: Being Changed and Open (Tentative)) come through just fine.

I may have misunderstood what you described, either way I need more detailed steps to reproduce in order to look into this. The steps I described above are an example of what I'm looking for.

I also wrote up a short guide for submitting issues and while this issue is generally okay (at least an attempt to describe steps to reproduce) this guidelines here will be helpful to both of us:

https://github.com/moqui/moqui-framework/wiki/Issue-and-Pull-Request-Guide

@jonesde jonesde closed this as completed Nov 19, 2017
@jonesde jonesde reopened this Nov 19, 2017
@jenshp
Copy link
Member Author

jenshp commented Nov 20, 2017

Steps to reproduce:

  1. start with latest moqui-framework and moqui-runtime (nothing else needed)
  2. change screen ArtifactHitSummary.xml in base-component (see changes_diff.txt)
    2.a. change header-dialog to "false" in "ArtifactHitSummaryList" form-list.
    2.b. add allow-multiple="true" to the drop-down tag of the "artifactType" field
    2.c add an actions section:
    <actions><log message="artifactType: ${artifactType}"/></actions>
  3. load demo data and run
  4. go to http://localhost:8080/apps/system/ArtifactHitSummary
  5. select only "AT_ENTITY" Artifact Type and press "Find"
  6. select "AT_ENTITY" and "AT_XML_SCREEN" as Artifact Type and press find.
  7. go to http://localhost:8080/vapps/system/ArtifactHitSummary (this one using the vuet interface)
  8. select only "AT_ENTITY" Artifact Type and press "Find"
  9. select "AT_ENTITY" plus another Artifact Type such as "AT_XML_SCREEN" and press find.

Expected results:
Step 9 should show the same results as step 6 (all hits for the artifact types AT_ENTITY or AT_XML_SCREEN)

Outcome:
No results are shown in step 9, while selecting only AT_ENTITY at step 8 shows several results.
At step 9, the actions section we added will generate a log entry like:
o.m.i.c.LoggerFacadeImpl artifactType: AT_XML_SCREEN,AT_ENTITY
while the working step 6 it will generate a log entry like:
o.m.i.c.LoggerFacadeImpl artifactType: [AT_XML_SCREEN, AT_ENTITY]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants