Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Review #42

Open
grappler opened this issue Dec 4, 2014 · 2 comments
Open

Theme Review #42

grappler opened this issue Dec 4, 2014 · 2 comments
Assignees

Comments

@grappler
Copy link
Contributor

grappler commented Dec 4, 2014

As I was doing the PR #41 I saw a few things that could be improved.

  • As the image size handles are not prefixed they could class with a plugin if it had the same handle.
    https://github.com/mor10/simone/blob/master/functions.php#L60-64
  • You should be using only one option in the database. The settings should be saved in a single array. So the setting would be simon_settings and everything would be saved in there. The problem is in line 35 of customizer.php It should be 'simon_settings[simone_header_color]'
  • The setting output should be escaped in simone_customizer_css().
  • There is no use for simon.mo. It can be deleted.
@mor10
Copy link
Owner

mor10 commented Dec 5, 2014

Thanks for doing this @grappler. I'll flag these and get them sorted in the next update.

Just fyi on point 2: The first setting is old, the second is new. I added more features and started messing with the structure of the whole document and the result was I overlooked the old stuff.

@mor10 mor10 self-assigned this Dec 5, 2014
@stevengutierrez
Copy link

Feature request:
Ability to add a logo to the header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants