Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py should always pass pyflakes #112

Open
jayvdb opened this issue Jul 19, 2019 · 0 comments
Open

setup.py should always pass pyflakes #112

jayvdb opened this issue Jul 19, 2019 · 0 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 19, 2019

Spawned from #81

Relevant pyflakes rules are no unused variables/imports.

Fixing unused variables is simply about template logic considering the moban variables before emitting the header of the .py file.

The template logic may get a tiny bit complex for imports, as there are several import styles, but this issue isnt about the style, as pyflakes doesnt care about that. However, the solution shouldnt be worse import style than the current code, so a little care is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant