From ff6fced82a0d962e50898e71f637d6b6c5f92c7c Mon Sep 17 00:00:00 2001 From: Morgan Ney Date: Thu, 25 Jan 2024 13:21:17 -0600 Subject: [PATCH] ci: update deps. (#193) * test: better playwright locator. --- .github/workflows/ci.yml | 8 ++++---- .github/workflows/e2e.yml | 8 ++++---- tests/geolocation/deny.spec.ts | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0470b11..ca7fbae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,15 +14,15 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3.5.2 + uses: actions/checkout@v4.1.1 - name: Setup Node - uses: actions/setup-node@v3.6.0 + uses: actions/setup-node@v4.0.1 with: - node-version: '20.10.0' + node-version: '20.11.0' - name: Install Dependencies run: npm ci - name: Save error log - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4.3.0 if: ${{ failure() }} with: name: npm-debug-log-${{ hashFiles('package-lock.json') }} diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 0e046d2..54702b4 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -41,9 +41,9 @@ jobs: mkcert -key-file busmap.localhost-key.pem -cert-file busmap.localhost.pem busmap.localhost localhost cp *.pem packages/web/certs - name: Setup Node - uses: actions/setup-node@v3.6.0 + uses: actions/setup-node@v4.0.1 with: - node-version: '20.10.0' + node-version: '20.11.0' - name: Install Dependencies run: npm ci - name: Install Playwright @@ -68,8 +68,8 @@ jobs: SSO_GOOG_CLIENT_ID: ${{ secrets.SSO_GOOG_CLIENT_ID }} SSO_GOOG_CLIENT_SECRET: ${{ secrets.SSO_GOOG_CLIENT_SECRET }} - name: Upload Test Results - uses: actions/upload-artifact@v3 - if: always() + uses: actions/upload-artifact@v4.3.0 + if: failure() with: name: playwright-report path: test-results diff --git a/tests/geolocation/deny.spec.ts b/tests/geolocation/deny.spec.ts index ecc6ed7..b4a1745 100644 --- a/tests/geolocation/deny.spec.ts +++ b/tests/geolocation/deny.spec.ts @@ -12,7 +12,7 @@ test('Deny geolocation use selector to find stop.', async ({ page }) => { await page.getByRole('listitem', { name: 'Selector' }).getByRole('button').click() await expect(page.getByRole('heading', { name: 'Bus Selector' })).toBeVisible() await page.getByText('Agency').click() - await page.getByPlaceholder('Agencies ... (64)').fill('toronto') + await page.getByLabel(/Agency/).fill('toronto') await page.getByRole('option', { name: 'Toronto Transit Commission' }).click() await page.getByText('Stop', { exact: true }).click() await page.getByRole('option', { name: 'Bathurst St At Neptune Dr' }).click()