Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vivify CMake fixes #180

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Vivify CMake fixes #180

merged 1 commit into from
Jul 28, 2024

Conversation

octurion
Copy link
Contributor

@octurion octurion commented Jul 27, 2024

The check for bfd.h in vivify/CMakeLists.txt fails (thus Vivify does not get built) because it is omitting the PACKAGE and PACKAGE_VERSION defines (unlike what appears to be the case in CallResolver.H).

Also, add a missing reference to <stdexcept>.

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (827dfdf) to head (bcd5e83).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   70.04%   70.04%   -0.01%     
==========================================
  Files          81       81              
  Lines        5769     5775       +6     
==========================================
+ Hits         4041     4045       +4     
- Misses       1728     1730       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mani-D Mani-D merged commit 6fb63e3 into morganstanley:main Jul 28, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants