Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Function Documentation For A Multiple Functions #3

Closed
mattssca opened this issue Aug 3, 2023 · 4 comments · Fixed by #34
Closed

Missing Function Documentation For A Multiple Functions #3

mattssca opened this issue Aug 3, 2023 · 4 comments · Fixed by #34
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@mattssca
Copy link
Contributor

mattssca commented Aug 3, 2023

The following functions are currently missing documentation:

  • bins_to_bedgraph.R
  • cache_output.R
  • check_file_details.R
  • compare_coding_mutation_pattern.R
  • copy_no_clobber.R
  • gene_mutation_tally.R
  • get_template_wildcards.R
  • get_unmatched_normals.R
  • grob_wildcards.R
  • socketWrite.R
  • test_glue.R
  • web_add_update_page.R
@Kdreval
Copy link
Contributor

Kdreval commented Aug 3, 2023

Thanks for tracking these! We would also as part of this would probably want the noRd tags to be removed so each function can generate it's own markdown with documentation and be displayed in the help

@mattssca
Copy link
Contributor Author

mattssca commented Aug 3, 2023

100%

@rdmorin
Copy link
Contributor

rdmorin commented Aug 3, 2023

Some of these aren't actually GAMBLR functions (e.g. socketWrite) and others probably never belonged in GAMBLR to begin with (e.g. test_glue).

@mattssca mattssca added the documentation Improvements or additions to documentation label Nov 24, 2023
@Kdreval
Copy link
Contributor

Kdreval commented Mar 14, 2024

Here is the current list returned by check:

❯ checking for missing documentation entries ... WARNING
  Undocumented code objects:
    ‘bins_to_bedgraph’ ‘cache_output’ ‘check_config_value’
    ‘check_file_details’ ‘cnames’ ‘coding_class’ ‘coding_vc’
    ‘colour_aliases’ ‘compare_coding_mutation_pattern’ ‘copy_no_clobber’
    ‘gene_mutation_tally’ ‘get_template_wildcards’
    ‘get_unmatched_normals’ ‘grob_wildcards’ ‘handle_metadata’
    ‘maf_header’ ‘rainfall_conv’ ‘required_cols’ ‘sanity_check_metadata’
    ‘socketWrite’ ‘standardize_chr_prefix’ ‘subset_cnstates’
    ‘trim_scale_expression’ ‘vc_nonSynonymous’
    ‘web_initialize_gambl_site’
  All user-level objects in a package should have documentation entries.
  See chapter ‘Writing R documentation files’ in the ‘Writing R
  Extensions’ manual.

@Kdreval Kdreval self-assigned this Mar 14, 2024
@Kdreval Kdreval mentioned this issue Mar 15, 2024
@Kdreval Kdreval linked a pull request Mar 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants