Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The get_cnv_and_ssm_status is outdated #26

Closed
Kdreval opened this issue Dec 15, 2023 · 0 comments
Closed

The get_cnv_and_ssm_status is outdated #26

Kdreval opened this issue Dec 15, 2023 · 0 comments
Assignees
@vladimirsouza
Labels
bug Something isn't working

Comments

@Kdreval
Copy link
Contributor

Kdreval commented Dec 15, 2023

This function operates outdated parameters like genome_build and at some places calls for a combination of arguments that does not make sense, like here:

GAMBLR.results/R/get_cnv_and_ssm_status.R

Lines 205 to 206 in 59620ce

projection = genome_build,
genome_build = genome_build,

It needs to be brought up to date with the argument naming and code can be streamlined to be more accurate
@mattssca mattssca added the bug Something isn't working label Dec 15, 2023
@rdmorin rdmorin closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladimirsouza vladimirsouza

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rdmorin @vladimirsouza @mattssca @Kdreval