Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions are not refreshed when adding a role to a permission #9

Open
puzzledmonkey opened this issue Jun 4, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@puzzledmonkey
Copy link

When adding a permission to a role it works fine, but when adding a role to a permission, the ForgetCachedPermissions listener does not fire.

The fix is to just check for the role class as well (in ForgetCachedPermissions)

$permissionKey = (Nova::resourceForModel(app(PermissionRegistrar::class)->getPermissionClass()))::uriKey();
$roleKey = (Nova::resourceForModel(app(PermissionRegistrar::class)->getRoleClass()))::uriKey();

if ($request->viaRelationship === $permissionKey || $request->viaRelationship === $roleKey) {
    app(PermissionRegistrar::class)->forgetCachedPermissions();
}
@moroneyio moroneyio self-assigned this Jun 5, 2022
@moroneyio moroneyio added the bug Something isn't working label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants