Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit fixes #85

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Audit fixes #85

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c057a50
refactor: factor parameter computation
peyha Oct 18, 2024
74c4fae
doc: small readme improvement
peyha Oct 18, 2024
3f2d67c
doc: prelcf exploit
peyha Oct 18, 2024
ef5fb17
doc: readme improvement
peyha Oct 18, 2024
91392a7
fix: errors lib solidity version
peyha Oct 18, 2024
f46dd4b
doc: readme
peyha Oct 18, 2024
fd3ddd5
doc(readme): improvement
peyha Oct 21, 2024
e530472
doc(readme): typo
peyha Oct 21, 2024
ee18fc0
doc: specify wad scaling
peyha Oct 21, 2024
3d086f1
doc(readme): improvements
peyha Oct 24, 2024
30eeb67
doc(readme): solidity version disclaimer
peyha Oct 24, 2024
c951b54
doc(readme): improvements
peyha Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ The [`PreLiquidationAddressLib`](./src/libraries/periphery/PreLiquidationAddress

### Potential preLCF manipulation

A pre-liquidation cannot pre-liquidate a proportion of the position's debt greater than `preLCF`, however it's possible to pre-liquidate a proportion of the position while keeping it pre-liquidatable before performing another pre-liquidation.
A pre-liquidation cannot repay a proportion of the position's debt greater than `preLCF`.
However it's possible to pre-liquidate a proportion of the position while keeping it pre-liquidatable before performing another pre-liquidation.
This manipulation can lead to repaying a proportion of the position's debt higher than `preLCF`.
It has been studied in the part 5.2 of [An Empirical Study of DeFi Liquidations:Incentives, Risks, and Instabilities](https://arxiv.org/pdf/2106.06389), in the case of a constant liquidation close factor.
Implementing a `preLCF` linear in the health factor can help mitigating this manipulation when choosing the right slope.
Expand All @@ -81,6 +82,11 @@ Install [Foundry](https://book.getfoundry.sh/getting-started/installation).

Run `forge test`.

## Solidity version

The main contracts (`PreLiquidation` and `PreLiquidationFactory`) are written in Solidity 0.8.27.
The bytecode of these contracts could contain new opcodes (e.g., `PUSH0`, `MCOPY`, `TSTORE`, `TLOAD`) so one should make sure that the contract bytecode can be handled by the chain used for deployment.

## Audits

All audits are stored in the [`audits`](./audits) folder.
Expand Down