Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the readme. #236

Merged
merged 3 commits into from
Dec 13, 2017
Merged

Updates the readme. #236

merged 3 commits into from
Dec 13, 2017

Conversation

dbazuin
Copy link
Contributor

@dbazuin dbazuin commented Oct 1, 2017

I updated the readme file as a temporarly fix for "Themes can not declare dependencies on modules #229"

@dbazuin dbazuin requested review from a team and mortendk October 2, 2017 15:15
scubafly
scubafly approved these changes Oct 19, 2017
View reviewed changes
Copy link

@scubafly scubafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree for now this would help people installing the theme.

@mortendk
Copy link
Owner

upsie looks like we should remove the dependency on the help module

@mortendk mortendk merged commit 9fc39f9 into mortendk:8.x-1.x Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scubafly scubafly scubafly approved these changes

@mortendk mortendk mortendk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbazuin @mortendk @scubafly