-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save checkpoint to disk for API with new save layout #3399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mihir Patel <[email protected]>
Co-authored-by: Mihir Patel <[email protected]>
Co-authored-by: Mihir Patel <[email protected]>
Co-authored-by: Mihir Patel <[email protected]>
…into save-layout
…into save-layout
mvpatel2000
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, would be helpful to have someone check though, many moving parts here
bigning
approved these changes
Jun 20, 2024
Co-authored-by: Mihir Patel <[email protected]>
…into save-layout
mvpatel2000
pushed a commit
to mvpatel2000/composer
that referenced
this pull request
Jul 21, 2024
mvpatel2000
pushed a commit
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces an API for saving the common objects one would save in a checkpoint:
These functions make sure to save each object into its own directory
Introduces a dataclass,
CheckpointSaveOptions
for configuring checkpoint savingIntroduces a save to disk workhorse function,
save_checkpoint_to_disk
that handles saving all components of a checkpoint. Uses the API in 1. to save each component into its own separate fileExtras:
init_state
helper function for tests to initialize a State object for tests