-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch/microbatch transforms #3703
Add batch/microbatch transforms #3703
Conversation
CC: @Ghelfi |
Thanks @mvpatel2000 ! Will there be a new release following this merge? The regression introduced in |
We're still figuring out when it would be released. To unblock, I recommend adding a transform that just moves batch to device. |
Thanks! That is exactly the patch we have right now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Thanks for quick implementation. |
What does this PR do?
#3566 moved device transfers into the microbatch loop. This results in device transformations occurring on CPU, which can be slow as pointed out in #3699.
To remedy this, we deprecate
device_transforms
(which was poorly named anyways) and instead addbatch_transforms
andmicrobatch_transforms
to dataspec. Batch transforms happens on CPU, and microbatch transforms happens on GPU after the device transfer.Additionally, if users want to do batch level transforms on GPU, they can add a transform that moves to device.