Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceRegistry: add Nacos V2 support #258

Open
spacewander opened this issue Jan 29, 2024 · 5 comments
Open

ServiceRegistry: add Nacos V2 support #258

spacewander opened this issue Jan 29, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@spacewander
Copy link
Member

Description

Currently, we only have Nacos V1 support.

According to https://nacos.io/en-us/docs/v2/guide/user/open-api.html

Nacos 2.X is compatible with Nacos 1.X OpenAPI

We should work for Nacos V2 now. But it would be better to add Nacos V2 support explicitly.

Use Scenes

No response

Advice

No response

@spacewander spacewander added the enhancement New feature or request label Jan 29, 2024
@duxin40
Copy link

duxin40 commented Feb 6, 2024

I am interested in this support, could you assign it to me?

@spacewander
Copy link
Member Author

We can add the V2 support at https://github.com/mosn/htnn/tree/main/controller/registries/nacos. The majority of code can be shared.

@duxin40
Copy link

duxin40 commented Feb 6, 2024

We can add the V2 support at https://github.com/mosn/htnn/tree/main/controller/registries/nacos. The majority of code can be shared.

ok

@spacewander
Copy link
Member Author

Hi @duxin40,
This particular issue is dedicated to the participants of the Summer OSPP 2024 program: https://summer-ospp.ac.cn/.
Could you please consider checking out some other 'good first issues' here: https://github.com/mosn/htnn/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22?
We appreciate your interest in our project!

@duxin40
Copy link

duxin40 commented May 10, 2024

Hi @duxin40, This particular issue is dedicated to the participants of the Summer OSPP 2024 program: https://summer-ospp.ac.cn/. Could you please consider checking out some other 'good first issues' here: https://github.com/mosn/htnn/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22? We appreciate your interest in our project!

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants