Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several OMPL interface tests started failing with humble_ci job on main #3130

Closed
sea-bass opened this issue Nov 23, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@sea-bass
Copy link
Contributor

sea-bass commented Nov 23, 2024

Description

This only started a few days ago (w.r.t. the issue creation date):
https://github.com/moveit/moveit2/actions/runs/11988362896/job/33423544280

This is unique to the humble_ci job on the main branch -- we need to either pinpoint and fix the cause of failure, or draw the line to say building that the main branch from source no longer works on Humble.

I'd like to see if we can figure out the issue first, and only resort to the latter option if absolutely necessary.

ROS Distro

Humble

OS and version

Ubuntu 22.04

Source or binary build?

Source

If binary, which release version?

No response

If source, which branch?

No response

Which RMW are you using?

None

Steps to Reproduce

https://github.com/moveit/moveit2/actions/runs/11988362896/job/33423544280

Expected behavior

Tests should pass

Actual behavior

Tests do not pass

Backtrace or Console output

No response

@sea-bass sea-bass added the bug Something isn't working label Nov 23, 2024
@rr-tom-noble
Copy link
Contributor

Related to #1952

It seems to be geometric_shapes throwing the error. Specifically, these lines

@sea-bass
Copy link
Contributor Author

sea-bass commented Nov 26, 2024

Ah! Yeah, turns out there was a commit to geometric_shapes that landed 5 days ago: moveit/geometric_shapes#239

And this repo is actually building it from source in the moveit2.repos file.

I've attempted to pin the SHA of this dependency in #3132 to see if this is it... my money is on https://github.com/moveit/geometric_shapes/pull/239/files#diff-987d05e9b43d06b27d53a909a70db53241e54e674d2a2ba59ac17f9c4a19cd8fR49-R52

Seems they forgot to forward port the full functionality, and this seems to be a float vs. double thing: moveit/geometric_shapes@96b34aa

From CI output, a full revert of that offending commit fixes the issue (https://github.com/moveit/moveit2/actions/runs/12021713374/job/33513194087?pr=3132) -- but I am bisecting now to see what's up.

@sea-bass
Copy link
Contributor Author

Found the issue. moveit/geometric_shapes#252 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants