Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tutorials to pipeline refactoring changes #834

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Update tutorials to pipeline refactoring changes #834

merged 4 commits into from
Dec 7, 2023

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Dec 6, 2023

@sjahr
Update tutorials
06fcaf6 
Name planning pipeline correctly

Update tutorial

Update motion planning API tutorial

Apply suggestions from code review

Address review comment

Remove config
@sjahr sjahr mentioned this pull request Dec 6, 2023
Draft
2 tasks
@sjahr sjahr changed the title Update tutorials Update tutorials to pipeline refactoring changes Dec 6, 2023
@sjahr sjahr mentioned this pull request Dec 6, 2023
Closed
9 tasks
@sjahr sjahr enabled auto-merge (squash) December 6, 2023 22:35
@sjahr sjahr requested review from tylerjw and sea-bass December 6, 2023 23:09
@sjahr sjahr mentioned this pull request Dec 6, 2023
Closed
2 tasks
@sjahr
Copy link
Contributor Author

sjahr commented Dec 7, 2023

CI failure does not seem to be related to this PR https://github.com/ros-planning/moveit2_tutorials/actions/runs/7121969390

@sea-bass
Copy link
Contributor

sea-bass commented Dec 7, 2023

CI failure does not seem to be related to this PR https://github.com/ros-planning/moveit2_tutorials/actions/runs/7121969390

Fix in moveit2 is here: moveit/moveit2#2584

@sea-bass sea-bass disabled auto-merge December 7, 2023 16:36
@sea-bass sea-bass self-requested a review December 7, 2023 16:58
@sjahr sjahr merged commit 11710ca into moveit:main Dec 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjw tylerjw Awaiting requested review from tylerjw

@sea-bass sea-bass Awaiting requested review from sea-bass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjahr @sea-bass