Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libs/movex] Fix Linting Issues Across the Movex Library #233

Open
GabrielCTroia opened this issue Oct 13, 2024 · 2 comments · May be fixed by #238
Open

[libs/movex] Fix Linting Issues Across the Movex Library #233

GabrielCTroia opened this issue Oct 13, 2024 · 2 comments · May be fixed by #238
Assignees
@ManikantaMandala
Labels
beginner-friendly This is a good issue if you're beginning with JS/TS or with Movex code-quality good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest hacktoberfest2024 up-for-grabs An issue that doesn't anyone assigned to it anymore

Comments

@GabrielCTroia
Copy link
Contributor

Where

  • /libs/movex/src/lib/ConnectionToMasterResources.ts
  • libs/movex/src/lib/MovexResourceObservable.spec.ts

What

There are a few linting issues in the codebase that need to be addressed to improve overall code quality. These linting issues are flagged by our linter, and resolving them will help keep the codebase clean and consistent.
Screenshot 2024-10-13 at 5 13 38 PM

Tasks

  1. Run the linter on the codebase (e.g., npx nx lint movex --quiet).
  2. Fix any linting issues that are flagged.
  3. Ensure that the code passes the linter without any errors or warnings after your fixes.
  4. Create a pull request with your changes.

Complexity:

Beginner-Friendly
@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest up-for-grabs An issue that doesn't anyone assigned to it anymore hacktoberfest2024 beginner-friendly This is a good issue if you're beginning with JS/TS or with Movex code-quality labels Oct 13, 2024
@ManikantaMandala
Copy link

Hey I want to work on this
can you assign this to me

@GabrielCTroia
Copy link
Contributor Author

yes, of course @ManikantaMandala

ManikantaMandala added a commit to ManikantaMandala/movex that referenced this issue Oct 15, 2024
@ManikantaMandala
Fix [libs/movex] fix Linting Issues Across the Movex Library movestha…
57efe08 
…tmatter#233
@ManikantaMandala ManikantaMandala linked a pull request Oct 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManikantaMandala ManikantaMandala

Labels
beginner-friendly This is a good issue if you're beginning with JS/TS or with Movex code-quality good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest hacktoberfest2024 up-for-grabs An issue that doesn't anyone assigned to it anymore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix [libs/movex] fix Linting Issues Across the Movex Library #233 ManikantaMandala/movex
2 participants
@GabrielCTroia @ManikantaMandala