Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libs/movex] Add Specs to the MemoryMovexStore Specs to test the "Delete" functionality in CRUD #45

Closed
GabrielCTroia opened this issue Oct 7, 2023 · 3 comments
Closed

[libs/movex] Add Specs to the MemoryMovexStore Specs to test the "Delete" functionality in CRUD #45

GabrielCTroia opened this issue Oct 7, 2023 · 3 comments
Assignees
@vishalda
Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest

Comments

@GabrielCTroia
Copy link
Contributor

Where

libs/movex/src/lib/movex-store/MemoryMovexStore.spec.ts

What

Add tests to assert the "Delete" functionality - the remove() method

Why

To ensure the store works correctly

Definition of done

  • it tests valid item deletion
  • it tests invalid item deletion (i.e. inexistent item)
  • tests a newly created item deletion
  • tests a newly updated item deletion
  • tests a newly delete item deletion
  • all other tests are still passing
@GabrielCTroia GabrielCTroia added good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest labels Oct 7, 2023
@vishalda
Copy link
Contributor

vishalda commented Oct 8, 2023

Hi @GabrielCTroia, I would like to work on this issue.

@GabrielCTroia
Copy link
Contributor Author

And it shall be yours! 🙏 Thank you

@vishalda vishalda mentioned this issue Oct 10, 2023
Merged
1 task
@GabrielCTroia
Copy link
Contributor Author

Closed in #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishalda vishalda

Labels
good first issue Good for newcomers hacktoberfest Improvements that qualify for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GabrielCTroia @vishalda