Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moxie/core/utils/Dom/getPos and inline-level element #82

Open
daohoangson opened this issue May 5, 2014 · 4 comments
Open

moxie/core/utils/Dom/getPos and inline-level element #82

daohoangson opened this issue May 5, 2014 · 4 comments

Comments

@daohoangson
Copy link

The getPos() method uses offsetTop and offsetLeft to calculate the element position relative to its offset parent. For inline-level elements, the value of offsetTop and offsetLeft has different meaning as described here. IMHO, this should be considered a bug and worth fixing.

Thank you.

@jayarjo
Copy link
Contributor

jayarjo commented May 7, 2014

Do you think we should wrap the Plupload across multiple lines?

@daohoangson
Copy link
Author

No, doing that would be silly.

I think we should adopt jQuery approach for this in order to calculate the "correct" offset. Otherwise the shim will be misplaced.

@jayarjo
Copy link
Contributor

jayarjo commented May 8, 2014

And what is jQuery's approach?

@daohoangson
Copy link
Author

Here https://code.google.com/p/jqueryjs/source/browse/trunk/jquery/src/offset.js, a bit overkill for our purpose though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants