Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: Add final gallery images #15307 #15587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson commented Nov 28, 2024

One-line summary

Add final gallery images #15307

Significant changes and points to review

  • Images sizes were chosen to address:
    • highest possible request size in high res
    • highest likely request size in both high and low res
    • lowest likely request size (lower is always possible)
    • if there was a large file size gap between those sizes likely middle sizes were picked
    • I honestly don't know what the right decision is here and I can share my spreadsheet if you like but I'd mostly prefer not to have to think about this again for a few weeks.
  • everything below 1440px sizing was calculated without taking gutters into account, since the sizes media query does not take gutters into account
    • we can't pass CSS variables to sizes so it starts to be come unmanageable to consider gutters (they're only 16px wide so it's not a big performance hit)
  • all images should be .jpg and optimized
  • alt text is not final so I did not wrap it for l10n
    • it's important to get feedback on what we have
    • we can make the display conditional on translation once we have them

Issue / Bugzilla link

#15307

Testing

Test at 1920, 1440, 1366, 1280, 1024, 768, 640, 360.
Test in both high and low res.

@stephaniehobson stephaniehobson requested a review from a team as a code owner November 28, 2024 01:07
@stephaniehobson stephaniehobson added Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour Refresh 🦖 Work related to the 2024 site refresh Frontend HTML, CSS, JS... client side stuff labels Nov 28, 2024
@stephaniehobson stephaniehobson changed the title Refresh: Final gallery images #15307 Refresh: Add final gallery images #15307 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review Refresh 🦖 Work related to the 2024 site refresh Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant