Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove project from DeleteSource table in shredder_targets #6573

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Remove project from DeleteSource table in shredder_targets #6573

merged 2 commits into from
Dec 2, 2024
+66 −5

Conversation

BenWu
Copy link
Contributor

@BenWu BenWu commented Nov 27, 2024 •
edited by data-sync-user
Loading

Description

Fix for #6541

project shouldn't be in the DeleteSource because it doesn't match what's in the shredder config.py and also breaks the table and dataset properties of the object. I also added a check to the constructor to validate the table value

Reviewer, please follow this checklist

┆Issue is synchronized with this Jira Task

@dataops-ci-bot
Copy link

Integration report for "fix"

sql.diff

Click to expand! 
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py	2024-11-27 19:00:06.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py	2024-11-27 19:00:04.000000000 +0000
@@ -185,13 +185,13 @@
                     stable_table_ref.dataset_id[: -len("_stable")]
                     in glean_channel_names
                 ):
-                    deletion_request_table = (
-                        f"{stable_table_ref.project}.{stable_table_ref.dataset_id}.deletion_request_v1"
-                    )
-                    if table_exists(client, deletion_request_table):
+                    if table_exists(
+                        client,
+                        f"{stable_table_ref.project}.{stable_table_ref.dataset_id}.deletion_request_v1",
+                    ):
                         table_to_deletions[stable_table] = {
                             DeleteSource(
-                                table=deletion_request_table,
+                                table=f"{stable_table_ref.dataset_id}.deletion_request_v1",
                                 field=GLEAN_CLIENT_ID,
                                 project=SHARED_PROD,
                             )

Link to full diff

@BenWu BenWu requested a review from akkomar November 27, 2024 19:25
@BenWu BenWu added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 9ce464f Dec 2, 2024
21 checks passed
@BenWu BenWu deleted the benwu/shredder-targets-no-project branch December 2, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akkomar akkomar akkomar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenWu @dataops-ci-bot @akkomar