Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Use custom geckodriver with support for Android #15

Open
ncalexan opened this issue Jun 3, 2019 · 3 comments
Open

Use custom geckodriver with support for Android #15

ncalexan opened this issue Jun 3, 2019 · 3 comments

Comments

@ncalexan
Copy link
Member

ncalexan commented Jun 3, 2019

Out of the box, browsertime installs geckodriver from

"@sitespeed.io/geckodriver": "0.24.0",

We can configure this by shipping our own package with modifications around https://github.com/sitespeedio/geckodriver/blob/89db79952a9e0660e6160809aff36c3164b9fd31/install.js#L31-L37

In particular, we can point to a custom geckodriver (temporarily, until Bug 1525126 lands). We can also fix a Windows bug where .exe is missing around https://github.com/sitespeedio/geckodriver/blob/89db79952a9e0660e6160809aff36c3164b9fd31/install.js#L105

@ncalexan
Copy link
Member Author

ncalexan commented Jun 3, 2019

/cc @sefeng211, who wants these binaries.

@ncalexan
Copy link
Member Author

ncalexan commented Jun 3, 2019

Try build that will produce said binaries is percolating here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=93814b0fb21f634d1cd70eca1e5168666263a094

@sefeng211
Copy link
Member

As we talked about it on Slack, there's probably an real issue about the custom geckodriver.
I have encountered this error quite a few times The previously configured GeckoDriver service is still running. You must shut it down before you may adjust its configuration.
I was able to fix it by reinstalling the app, but I couldn't anymore.

This is the full log : https://termbin.com/vbhm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants