You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
we should explicitely look at the firefox version and implement the right script for each supported Firefox version (and also throw a hard error in case it's not implemented. no need to go further like we do now)
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Why are we doing guesswork here by counting the number of arguments the API has ?
https://github.com/mozilla/browsertime/blob/master/lib/firefox/webdriver/firefoxDelegate.js#L54-L74
this leads to a fragile implementation, that gets broken everytime the API is changed, see #50
we should explicitely look at the firefox version and implement the right script for each supported Firefox version (and also throw a hard error in case it's not implemented. no need to go further like we do now)
The text was updated successfully, but these errors were encountered: