Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Stop guessing the GeckoProfiler API #51

Open
tarekziade opened this issue Dec 5, 2019 · 0 comments
Open

Stop guessing the GeckoProfiler API #51

tarekziade opened this issue Dec 5, 2019 · 0 comments

Comments

@tarekziade
Copy link

tarekziade commented Dec 5, 2019

Why are we doing guesswork here by counting the number of arguments the API has ?

https://github.com/mozilla/browsertime/blob/master/lib/firefox/webdriver/firefoxDelegate.js#L54-L74
this leads to a fragile implementation, that gets broken everytime the API is changed, see #50

we should explicitely look at the firefox version and implement the right script for each supported Firefox version (and also throw a hard error in case it's not implemented. no need to go further like we do now)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant