Update severity_inconsistency.py to NI the triage owner instead of an assignee when an accessibility severity is higher than the severity

[anna-yeddi]

The Bugbot sends an NI to an assignee alone, instead of the triage owner, when the accessibility severity is higher than the severity:

[email protected] ---
The severity field for this bug is set to S3. However, the accessibility severity is higher, . :ayeddi, could you consider increasing the severity?

Another approach could be to remove the "assigned_to" field at all since all the bugs have always "triage_owner" filled in.

Checklist

• Type annotations added to new functions
• Docs added to functions touched in main classes
• Dry-run produced the expected results
• The to-be-announced tag added if this is worth announcing

[marco-c]

@anna-yeddi we did this to decrease the load on triage owners, and spread needinfos across more people. I guess there are cases where it is suboptimal, e.g. when you are fixing a bug in a component that is unrelated to your team and so you have no direct control over severity.

@suhaibmujahid wdyt?

[suhaibmujahid]

@anna-yeddi we did this to decrease the load on triage owners, and spread needinfos across more people. I guess there are cases where it is suboptimal, e.g. when you are fixing a bug in a component that is unrelated to your team and so you have no direct control over severity.

@suhaibmujahid wdyt?

I agree. I also think that in most cases, the assignee may have more context and be more involved with the bug than the triage owner.

@anna-yeddi, could you please clarify why you prefer to needinfo the triage owner when the bug is already assigned?

[anna-yeddi]

@anna-yeddi we did this to decrease the load on triage owners, and spread needinfos across more people. I guess there are cases where it is suboptimal, e.g. when you are fixing a bug in a component that is unrelated to your team and so you have no direct control over severity.
@suhaibmujahid wdyt?

I agree. I also think that in most cases, the assignee may have more context and be more involved with the bug than the triage owner.

@anna-yeddi, could you please clarify why you prefer to needinfo the triage owner when the bug is already assigned?

@suhaibmujahid I think it's not necessary about the preference to the triage owner, but more that if the BugBot is asking to consider increasing severity, it should ask the person responsible of the lower severity rating, which is in many cases with me is not me (i.e. I already marked the bug access-S2) but the Triage owner (who set the severity to S3 prompting the BugBot nag).

If I really the only one getting these pings, I can continue redirecting them to the triage owners though. Possibly, it's more of an edge case since I'm from the Accessibility team but have to fix a11y bugs across the codebase to avoid user blockers.

[suhaibmujahid]

@anna-yeddi I see your point; thank you for the clarification. This makes sense. I discussed it with Marco, and he suggested that we could still needinfo the assignee if both the assignee and the triage owner work under the same manager. Otherwise, we needinfo the triage owner.

We can get the manger using the get_manager_mail() method from the People class:

bugbot/bugbot/people.py

Line 277 in 6966638

def get_manager_mail(self, mail):

Usually, when we use the People class, we first get an instance from the class in the constructer, example:

bugbot/bugbot/rules/bisection_without_regressed_by.py

Lines 68 to 69 in 27d55c4

	super().__init__()
	self.people = People.get_instance()

WDYT?