Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Rule] Detect WorksForMe Bugs #2362

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[New Rule] Detect WorksForMe Bugs #2362

wants to merge 3 commits into from

Conversation

PromiseFru
Copy link
Collaborator

@PromiseFru PromiseFru commented Feb 29, 2024 •
edited
Loading

New rule for detecting potential worksforme bugs.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@PromiseFru PromiseFru changed the title Add new rule for detecting potential worksforme bugs [New Rule] Detect WorksForMe Bugs Feb 29, 2024
suhaibmujahid
suhaibmujahid reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @PromiseFru! Please see my comments.

bugbot/rules/worksforme.py Outdated Show resolved Hide resolved
configs/rules.json Outdated Show resolved Hide resolved
suhaibmujahid
suhaibmujahid reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @PromiseFru! LGTM.

We can proceed with the merge once we successfully deploy the WorksForMe model and conduct a dry-run test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhaibmujahid suhaibmujahid suhaibmujahid left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PromiseFru @suhaibmujahid