Mention resolving perfalert as WONTFIX, and don't needinfo on bugs with backlog-deferred keyword. #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds some additional text to the needinfo to ask the developer to close the bug as WONTFIX if it's appropriate, and provides some documentation to help them with this decision.
At the same time, a
backlog-deferredkeyword check is added to prevent bugbot from making needinfo's on bugs who have this set. It signifies that the regression is valid, needs to be fixed or better understood, but won't be immediately fixed. It's not mentioned in the needinfo comment since it should be used sparingly, and in cases where this keyword is set, a follow-up bug can usually be made to look into the issue while resolving the alert as a WONTFIX.Furthermore, locally, private regressors cause failures so the retrieval of the regressor email is changed to use a get instead.