Merge pull request #5175 from mozilla/fix-log-group-id-mpp-3932

MPP-3942: Fix `log_group_id` in `developer_mode` log
mozilla · Nov 7, 2024 · bd7b824 · bd7b824
2 parents bf32123 + 8bf7c57
commit bd7b824
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/emails/tests/views_tests.py b/emails/tests/views_tests.py
@@ -832,6 +832,7 @@ def test_developer_mode_simulate_complaint(self, mock_logger: Mock) -> None:
             if log_group_id is None:
                 log_group_id = extra["log_group_id"]
                 assert log_group_id
+                assert isinstance(log_group_id, str)
             else:
                 assert extra["log_group_id"] == log_group_id
             parts[extra["part"]] = extra["notification_gza85"]

diff --git a/emails/views.py b/emails/views.py
@@ -993,7 +993,7 @@ def _log_dev_notification(
 
     notification_gza85 = encode_dict_gza85(notification)
     total_parts = notification_gza85.count("\n") + 1
-    log_group_id = uuid4()
+    log_group_id = str(uuid4())
     for partnum, part in enumerate(notification_gza85.splitlines()):
         info_logger.info(
             log_message,

diff --git a/package-lock.json b/package-lock.json