Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetstream validation for population ratio should check numerator & denominator #1852

Open
dzeber opened this issue Jul 20, 2023 · 0 comments

Comments

@dzeber
Copy link

dzeber commented Jul 20, 2023

I recently committed updates to the Navigational Suggestions experiment config in metric-hub. As a part of this I renamed the engaged_search_sessions metric to search_sessions, but I forgot to update the name in the denominator for nav_impression_rate and search_engine_rate.

However, the CI validation passed and the rerun-jetstream job completed successfully. I only noticed the error when I found that the statistics_ tables did not contain the nav_impression_rate and search_engine_rate metrics - looks like they were silently dropped because of the denominator error.

The validation should check the numerator & denominator for population ratio metrics and flag if either of these are not defined.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant