Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always_filter on date's in dimension groups prevent aggregate tables at other date levels. #388

Open
ANich opened this issue Mar 18, 2022 · 1 comment

Comments

@ANich
Copy link
Contributor

ANich commented Mar 18, 2022

For Explores that point to large tables like search_clients_daily, it's usually helpful to have aggregate tables smaller than the daily grain (weekly, monthly, etc.)

The always_filter on submission_date (https://github.com/mozilla/lookml-generator/blob/main/generator/explores/explore.py#L239-L240) for example means we can't aggregate to submission_month or submission_year so the fastest aggregate-aware queries we have will point to daily aggregates. We can get a lot faster for month/month year/year queries if we change that.

Opening this issue to gather thoughts on how to fix that.

One option is to remove the auto-generated always_filter for submission_date: 28 days in Explores eg. https://github.com/mozilla/looker-hub/blob/main/search/explores/desktop_search_counts.explore.lkml#L13-L17 and find another way to prevent huge scans. Any other ideas?

cc @Marlene-M-Hirose @scholtzan

@ANich
Copy link
Contributor Author

ANich commented Mar 18, 2022

Here's an example:
image

Ideally we'd have "Submission Month" in the past 3 months which would hit a monthly aggregated table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant