Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Customize Persona popup #601

Closed
stenington opened this issue Feb 22, 2013 · 10 comments
Closed

Customize Persona popup #601

stenington opened this issue Feb 22, 2013 · 10 comments
Assignees

Comments

@stenington
Copy link
Contributor

After #511 goes through, we can add parameters to navigator.id.request() as detailed in the docs to add a site logo and site name to the persona popup. The popup can also reference our Terms of Use and Privacy Policy.

@ghost ghost assigned stenington Feb 25, 2013
@cmcavoy
Copy link
Contributor

cmcavoy commented Mar 1, 2013

blocked on mozilla/persona#2999

@callahad
Copy link

callahad commented Mar 1, 2013

unblock yoself, the old .get() API also supports siteName, siteLogo, termsOfService, and privacyPolicy :)

(They're undocumented, but should absolutely work. That said, moving to .watch() is a much better, more supported option :))

@stenington
Copy link
Contributor Author

Oh, nice! I thought they had stopped working with .get(). Good to know we can move ahead with this one. Thanks @callahad!

@cmcavoy
Copy link
Contributor

cmcavoy commented Mar 8, 2013

@iamjessklein @threeqube @stenington marking this as a must-have, as it's a good MVP for Persona changes until mozilla/persona#2999 is fixed.

@threeqube
Copy link
Contributor

So are we moving forward with Observer API? Sorry I'm brainfarting on where we netted out on this.

@callahad
Copy link

callahad commented Mar 8, 2013

I would strongly recommend moving to the Observer API as soon as any blockers are resolved. Adding the branding info to .get() nets a nice stopgap measure, but it isn't able to offer strong integration with future browsers, nor can you get "sign me out everywhere" messages when a user changes a password / loses a device, nor can your user be redirected to your site and logged in in response to an email confirmation. :)

@stenington
Copy link
Contributor Author

@threeqube Yep, definitely moving to the Observer API once blockers are resolved, but it sounds like they won't be resolved next week. In the meantime, it turns out the Callback API supports a lot of the same customization options as the Observer API now.

@threeqube
Copy link
Contributor

@stenington got it. Hopefully blockers will be resolved soon so first time backpack creators don't land on that silly persona accounts management page that we get from using callback API for too long.

@trevor
Copy link

trevor commented Dec 6, 2013

this appears to be resolved

@threeqube
Copy link
Contributor

Indeed! Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants