Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and object struct members should be pointers #16

Open
ameihm0912 opened this issue Jul 25, 2017 · 0 comments
Open

Test and object struct members should be pointers #16

ameihm0912 opened this issue Jul 25, 2017 · 0 comments

Comments

@ameihm0912
Copy link

As an example:

scribe/test.go

Line 31 in 69bc11b

EVR EVRTest `json:"evr,omitempty" yaml:"evr,omitempty"` // EVR version comparison

This could be defined as EVR *EVRTest

The benefit here is if set nil, omitempty would behave correctly and not include this in resulting JSON documents. Currently, the types when marshaled can include a lot of useless sections, and being able to omit these correctly if not required would make them much smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant