Skip to content

Commit

Permalink
Bug 1861756 - don't try to trim test path for crashes (which are sing…
Browse files Browse the repository at this point in the history
…le tracking bugs)
  • Loading branch information
Archaeopteryx committed Oct 27, 2023
1 parent 25781ae commit 444c2f7
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
9 changes: 9 additions & 0 deletions tests/ui/job-view/bugfiler_test.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -352,4 +352,13 @@ describe('BugFiler', () => {
'TEST-UNEXPECTED-PASS | flee | floo',
);
});

test('should have summary as "single tracking bug"', () => {
const rawSummary =
'PROCESS-CRASH | application crashed [@ libc.so.6 + 0x0000000000114cf9] | /storage/estimate-usage-details-indexeddb.https.tentative.any.html';
const expected =
'application crashed [@ libc.so.6 + 0x0000000000114cf9] | single tracking bug';
const displayed = SummaryAndExpected(rawSummary);
expect(displayed).toBeInTheDocument(expected);
});
});
7 changes: 7 additions & 0 deletions ui/shared/BugFiler.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,13 @@ export class BugFilerClass extends React.Component {
].some((regexp) => regexp.test(summaryString));
}

if (crashSignatures) {
isTestPath = false;
const parts = summaryString.split(' | ');
summaryString = `${parts[0]} | single tracking bug`;
keywords.push('intermittent-testcase');
}

// trimming params from end of a test case name when filing for stb
let trimParams = false;

Expand Down

0 comments on commit 444c2f7

Please sign in to comment.