Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the WebCompat interventions code to re-use the shims code #231

Open
wisniewskit opened this issue Nov 16, 2021 · 0 comments
Open
Labels

Comments

@wisniewskit
Copy link

Issue #248

  • to reduce friction when creating interventions, it would be good to have one "type" of intervention, sharing the same single codebase/JSON file.
  • right now we have three: shims, UA overrides, and interventions. we can just make them all shims with some kind of "type" field.
  • this would consolidate the code, making it easier to know how to add a given intervention, and to fix some bugs.
  • this would also give us a chance to improve test coverage.
  • rough time estimate: one week of engineering time for the core refactor, and likely another week to improve test coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants