Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions of general standards #1

Open
mpadge opened this issue Oct 28, 2020 · 0 comments
Open

Revisions of general standards #1

mpadge opened this issue Oct 28, 2020 · 0 comments

Comments

@mpadge
Copy link
Owner

mpadge commented Oct 28, 2020

Points raised by @rkillick in her review of the brolgar package by @njtierney as "not covered but should be":

  • Visualizations being appropriate; this should be in the general standards section.
  • Mapping some of the specific standards to 1-d input variables onto tabular input. For instance, 1-d input specifies the type should be checked. This should also apply to the type for tabular input (necessarily each column for data frames).

The latter point is one which needs to be addressed in general standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant