Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forward product custom attributes #30

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mmustafa-tse
Copy link

Summary

  • A customer raised an issue that we don't forward product custom attributes to GA4/Firebase, after further investigation, I was able to verify that Google accept mapped custom attributes as mentioned here

Testing Plan

  • [Y] Was this tested locally? If not, explain why.
  • Unit tested and E2E tested (it takes 24 hours for results to show in Firebase for this case, breakpoints were showing to be forwarded as expected and will double verify tomorrow in GA4 dashboard)

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants