Default MQTT values (#47)

* Default MQTT values prevent breaking on upgrades * Adds the GitHub pull-req add-on for VS Code
mpepping · Jan 3, 2023 · 1d413ed · 1d413ed
1 parent 59f669f
commit 1d413ed
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -22,9 +22,10 @@
 			// Add the IDs of extensions you want installed when the container is created.
 			"extensions": [
 				"github.copilot",
+				"github.vscode-pull-request-github",
 				"ms-python.python",
-				"oderwat.indent-rainbow",
-				"ms-python.vscode-pylance"
+				"ms-python.vscode-pylance",
+				"oderwat.indent-rainbow"
 			]
 		}
 	},

diff --git a/solarman/helpers.py b/solarman/helpers.py
@@ -44,6 +44,8 @@
                 "topic": {"type": "string"},
                 "username": {"type": "string"},
                 "password": {"type": "string"},
+                "qos": {"type": "integer", "minimum": 1, "maximum": 1},
+                "retain": {"type": "boolean"},
             },
         },
     },

diff --git a/solarman/mqtt.py b/solarman/mqtt.py
@@ -22,8 +22,8 @@ def __init__(self, config):
         self.port = config["port"]
         self.username = config["username"]
         self.password = config["password"]
-        self.qos = config["qos"]
-        self.retain = config["retain"]
+        self.qos = config.get("qos", 1)
+        self.retain = config.get("retain", True)
         self.client = Mqtt.connect(self)
 
     def connect(self):