Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement leader election #65

Open
aslafy-z opened this issue May 30, 2023 · 2 comments
Open

Implement leader election #65

aslafy-z opened this issue May 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@aslafy-z
Copy link
Contributor

The thread memory feature does not work well when using multiple replicas.
Implementing leader election and forward inbound requests to the leader could solve this issue.

@mr-karan mr-karan added the enhancement New feature or request label May 30, 2023
@mr-karan
Copy link
Owner

I think using redis would be an easier approach than implementing leader elections in this tiny simple app.

@h4wkmoon
Copy link

I think it is easier to add leaderelection, which is a kubernetes standard than add a redis client in your app, and make every query read or write to the redis. But I'm not a skilled dev. You can find example of that, in kyverno source code, for instance.
From a "user" perpective, I would prefer that calert use election than having to deploy any additional redis pods.
From an architecture perpective, one would want to run redis in ha, to avoid a spof. This is getting too heavy for calert.

If a spof is acceptable, then we can run calert on a single pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants