feat: upgrade to v7.4 #154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 24 24
Lines 2672 2672
=======================================
Hits 2549 2549
Misses 84 84
Partials 39 39 ☔ View full report in Codecov by Sentry. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @mr-linch - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 5 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -336,13 +336,19 @@ func (call *SendMessageCall) ProtectContent(protectContent bool) *SendMessageCal | |||
| return call | |||
| } | |||
|
|
|||
| // MessageEffectID Unique identifier of the message effect to be added to the message; for private chats only | |||
There was a problem hiding this comment.
question: Clarify the scope of MessageEffectID
Consider clarifying whether MessageEffectID is applicable only to private chats or if it can be used in other contexts as well.
| @@ -559,6 +565,12 @@ | |||
| return call | |||
| } | |||
|
|
|||
| // ShowCaptionAboveMedia Pass True, if the caption must be shown above the message media. Ignored if a new caption isn't specified. | |||
There was a problem hiding this comment.
suggestion: Clarify the behavior of ShowCaptionAboveMedia
Consider clarifying the behavior when ShowCaptionAboveMedia is true, especially in cases where the media type does not support captions.
| // ShowCaptionAboveMedia Pass True, if the caption must be shown above the message media. Ignored if a new caption isn't specified. | |
| // ShowCaptionAboveMedia Pass True if the caption must be shown above the message media. Note: This may be ignored for media types that do not support captions or if a new caption isn't specified. |
| @@ -1850,8 +1946,8 @@ | |||
| // NewSendPollCall constructs a new SendPollCall with required parameters. | |||
| // chatID - Unique identifier for the target chat or username of the target channel (in the format @channelusername) | |||
| // question - Poll question, 1-300 characters | |||
| // options - A JSON-serialized list of answer options, 2-10 strings 1-100 characters each | |||
| func NewSendPollCall(chatID PeerID, question string, options []string) *SendPollCall { | |||
| // options - A JSON-serialized list of 2-10 answer options | |||
There was a problem hiding this comment.
suggestion: Clarify the format of options
Consider specifying the expected format or constraints of the options array.
| // options - A JSON-serialized list of 2-10 answer options | |
| // options - A JSON-serialized list of 2-10 answer options, each an InputPollOption object |
| // currency - Three-letter ISO 4217 currency code, see more on currencies | ||
| // prices - Price breakdown, a JSON-serialized list of components (e.g. product price, tax, discount, delivery cost, delivery tax, bonus, etc.) | ||
| func NewSendInvoiceCall(chatID PeerID, title string, description string, payload string, providerToken string, currency string, prices []LabeledPrice) *SendInvoiceCall { | ||
| // currency - Three-letter ISO 4217 currency code, see more on currencies. Pass “XTR” for payments in Telegram Stars. |
There was a problem hiding this comment.
suggestion: Clarify the use of 'XTR' for payments
Consider adding more context or a reference to documentation for the use of 'XTR' for payments in Telegram Stars.
| // currency - Three-letter ISO 4217 currency code, see more on currencies. Pass “XTR” for payments in Telegram Stars. | |
| // currency - Three-letter ISO 4217 currency code, see more on currencies. Pass “XTR” for payments in Telegram Stars. | |
| // currency - Three-letter ISO 4217 currency code, see more on currencies. Pass “XTR” for payments in Telegram Stars (see documentation for details). |
| @@ -6466,6 +6606,45 @@ | |||
| return call | |||
| } | |||
|
|
|||
| // RefundStarPaymentCall reprenesents a call to the refundStarPayment method. | |||
There was a problem hiding this comment.
issue (typo): Typo in comment
There is a typo in the comment: 'reprenesents' should be 'represents'.
BackgroundFillandBackgroundType(may be generate?)