You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Guzzle made the Client class (and most of its things) final, which means that a once useful way to extend a class is now useless for no reason. This could help remove the use of guzzle later on.
Proposed Resolution
Adds a client property to XeroClient.
Add public function XeroClientInterface::request(string $method, string|UriInterface $uri = '', array $options = []): ResponseInterface. This should create a Psr\Http\Message\RequestInterface instance probably from one of the from methods on Psr\Util or whatever.
Add a deprecated public function XeroClient::get(string|UriInterface $uri = '', array $options = []) because I mentioned get in the README. Maybe also a post and a put because those are used in Xero API.
Add public static function XeroClientInterface::createWithConfig(array $config, array $options) that returns a XeroClient instance.
Makes backwards-incompatible change to __construct method to only provide guzzle client.
Updates to documentation
Additional Information
N/A
The text was updated successfully, but these errors were encountered:
Problem/Motivation
Guzzle made the Client class (and most of its things) final, which means that a once useful way to extend a class is now useless for no reason. This could help remove the use of guzzle later on.
Proposed Resolution
public function XeroClientInterface::request(string $method, string|UriInterface $uri = '', array $options = []): ResponseInterface
. This should create a Psr\Http\Message\RequestInterface instance probably from one of the from methods on Psr\Util or whatever.public function XeroClient::get(string|UriInterface $uri = '', array $options = [])
because I mentioned get in the README. Maybe also a post and a put because those are used in Xero API.public static function XeroClientInterface::createWithConfig(array $config, array $options)
that returns a XeroClient instance.Additional Information
N/A
The text was updated successfully, but these errors were encountered: