Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber support #4

Open
orikremer opened this issue Nov 6, 2013 · 3 comments
Open

Cucumber support #4

orikremer opened this issue Nov 6, 2013 · 3 comments

Comments

@orikremer
Copy link

Would be great if this could be used for cucumber as well.

@mrbrdo
Copy link
Owner

mrbrdo commented Nov 6, 2013

Personally I don't use Cucumber, and am a bit short on time, but I would gladly review and accept any pull request regarding this. It should probably be just a few lines of code.

For example on how to implement, see how rspec is done (yes, this is all):
https://github.com/mrbrdo/theine/blob/master/lib/theine/worker.rb#L19
https://github.com/mrbrdo/theine/blob/master/lib/theine/client.rb#L41

@orikremer
Copy link
Author

@mrbrdo Thanks,
That's where I started, got cucumber to run my features (rails) but ran into what seems to be a cucumber load issue.

@mrbrdo
Copy link
Owner

mrbrdo commented Nov 6, 2013

Hm well what I can say is only that rails must be loaded before cucumber for theine, otherwise it defeats the purpose. If just requiring cucumber files does not do anything (e.g. stub stuff or anything like that) until you actually invoke cucumber's methods, you could try requiring cucumber in the load order that is necessary at the top of the worker file. This means of course that cucumber will be loaded into all workers (even if they are then used for rails console for example), that's why it's important requiring it does alter anything. There is a load order problem reported for capybara as well, perhaps we can take a similar approach for that also.

Not sure what else you could try except for finding out exactly what the problem is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants