-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard kit toms spend a long time in a nearly inaudible loop #2
Comments
Thank you for reporting this. The GeneralUser GS Standard Tom 5 is 2.3 seconds long and has a loop at the end. For melodic presets, I would handle this scenario by using the hold envelope phase for 2.3 seconds and then the decay phase would fade the loop out afterward. However, for percussion presets, many MIDI files use zero-length notes, so any and all sound shaping happens in the release phase. Too short of a release phase, and the sample fades out too quickly and gets buried in a mix. The 40 second release time on the Standard Tom 5 is to keep that primary 2.3 seconds of sample playing reasonably loudly, but is mostly spent on a barely audible loop. This doesn't just cause a delay to the end of the audio file rendering, but also unnecessarily chews up polyphony during song playback. I will look at a more elegant solution to this problem for the next GeneralUser GS revision. |
Many thanks for the quick response.. |
I'd still like to avoid having voices hanging around for so long since it uses up polyphony, so I will leave this issue open until I have addressed this. |
@mrbumpy409:
There has been a finding about General GS User v2 in the fluidsynth issues which might be relevant for an improvement. Please see here
The text was updated successfully, but these errors were encountered: