Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/metapopulation model #259

Merged
merged 23 commits into from
Jul 4, 2024
Merged

Feat/metapopulation model #259

merged 23 commits into from
Jul 4, 2024

Conversation

giovannic
Copy link
Member

No description provided.

giovannic and others added 16 commits July 18, 2023 12:11
 * Add rdt testing parameters
 * Update biting_process to consider rdt testing for mixing
- updating metapop vignette
- clarifying row & col meanings
 * Add rdt testing parameters
 * Update biting_process to consider rdt testing for mixing
 * refactor transmission mixing code
 * fix regressions
 * add time caching
 * Added export_mixing and import_mixing arguments to run_metapop_...
 * Update create_transmission_mixer to mix eir on import and foim on
   export
 * Fix regression tests
Add asymmetric transmission in mixing:
@htopazian htopazian changed the base branch from dev to master June 3, 2024 18:56
@htopazian htopazian changed the base branch from master to dev June 3, 2024 18:56
@htopazian htopazian requested a review from plietar June 6, 2024 14:36
@htopazian htopazian requested review from plietar and removed request for plietar June 26, 2024 08:25
Copy link
Member

@plietar plietar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my perspective this seems fine, but I don't really have the background context on what is being accomplished.

R/mixing.R Outdated Show resolved Hide resolved
R/mixing.R Outdated Show resolved Hide resolved
.gitignore Outdated
@@ -12,3 +12,4 @@ doc
inst/doc
/doc/
/Meta/
src-i386
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giovannic do you know why this was added?

htopazian and others added 2 commits July 1, 2024 11:43
Co-authored-by: Paul Liétar <[email protected]>
Co-authored-by: Paul Liétar <[email protected]>
@htopazian
Copy link
Contributor

Thanks @plietar, essentially we are fixing some assumptions in how the metapopulation model mixing matrix is made to allow for different effects on FOIM and EIR. We have done a lot of testing with it, but thanks for providing another set of eyes to the changes!

@giovannic giovannic merged commit e51c6bc into dev Jul 4, 2024
4 checks passed
@giovannic giovannic deleted the feat/metapopulation_model branch July 4, 2024 09:31
@giovannic giovannic mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants