Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/maternal immunity sampling #279

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

tbreweric
Copy link
Contributor

@tbreweric tbreweric commented Jan 15, 2024

The sample_maternal_immunity() function (in mortality_processes.R), which samples and assigns maternally-inherited immunity to clinical (icm) and severe (ivm) disease for a Bitset of target individuals (in practice those who have died and are being re-born into the population) currently calculates the maternally-inherited immunity to clinical and severe disease as follows:

birth_icm <- variables$ica$get_values(mothers) * parameters$pcm
birth_ivm <- variables$ica$get_values(mothers) * parameters$pvm

I think maternally inherited immunity to severe disease (birth_ivm) should presumably be calculated using the mothers acquired immunity to severe disease variables$iva), so have amended the calculation for maternally-inherited immunity to severe disease to the following:

birth_ivm <- variables$iva$get_values(mothers) * parameters$pvm

…he function now calculates the maternally-acquired immunity to severe disease (birth_ivm) using the acquired immunity to severe disease (iva) rather than the acquired immunity to clinical disease (ica)
@giovannic giovannic changed the base branch from master to dev January 15, 2024 16:20
Copy link
Member

@giovannic giovannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot. Thanks!

@giovannic
Copy link
Member

For reference, papers do not explicitly state which acquired immunity to use. But this change would make malariasimulation consistent with the previous model

@giovannic
Copy link
Member

And the equilibrium

Copy link
Member

@pwinskill pwinskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 🥇

@giovannic giovannic merged commit 0359cec into dev Jan 22, 2024
4 checks passed
@giovannic giovannic deleted the bug/maternal_immunity_sampling branch January 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants