Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File 01_cifar10_tinyvgg.ipynb comma problem #4

Open
RoversX opened this issue May 19, 2023 · 1 comment
Open

File 01_cifar10_tinyvgg.ipynb comma problem #4

RoversX opened this issue May 19, 2023 · 1 comment

Comments

@RoversX
Copy link

RoversX commented May 19, 2023

4. Train the model on CPU and MPS device (GPU)

Hello, I think This part "model": model.class.name, # Add a comma here, need to add a comma.

  # Create results dict
results = {
    "machine": MACHINE,
    "device": device,
    "dataset_name": DATASET_NAME,
    "epochs": NUM_EPOCHS,
    "batch_size": BATCH_SIZE,
    "image_size": IMAGE_SIZE[0],
    "num_train_samples": len(train_data),
    "num_test_samples": len(test_data),
    "total_train_time": round(total_train_time, 3),
    "time_per_epoch": round(total_train_time/NUM_EPOCHS, 3),
    "model": model.__class__.__name__,  # Add a comma here
    "test_accuracy": model_results["test_acc"][-1]
}

@planetf1
Copy link
Contributor

I hit the same issue when trying the benchmark, and also added the comma in my version.

I've proposed a PR for the change. Hope that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants