Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Tests #12

Closed
senden9 opened this issue Oct 27, 2018 · 3 comments · May be fixed by #17
Closed

Add more Tests #12

senden9 opened this issue Oct 27, 2018 · 3 comments · May be fixed by #17

Comments

@senden9
Copy link
Contributor

senden9 commented Oct 27, 2018

Hi!

I think, now that we have automatic CI test runs, a few more test would be helpful. For that i suggest to let the emulator panic or return an error if we hit an unknown command. At the moment unknown commands are simply ignored.

It is maybe a good idea to test against the 6502_functional_test.a65. What say the other people?

@mre
Copy link
Owner

mre commented Oct 28, 2018

Aye, that's a great idea!
Maybe there's a way to auto-generate some tests from the resource (and others) that you mentioned. Do you want to tackle that one?

@senden9
Copy link
Contributor Author

senden9 commented Oct 29, 2018

Also a good + funny idea. But I have not much spare time under the week. So will not claim that now.

@mre
Copy link
Owner

mre commented Jan 28, 2021

We got quite a few more unit tests now, so I'll go ahead and close this.
The functional test is still untouched but I don't think we should keep that issue open any longer. Probably there are better ways to do it by now than my crude attempt in #17.

@mre mre closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants